Add RetryPolicy.Handle Property to Allow for Exception Filtering on Retries#314
Conversation
…o CoreRetryOptions. Testing shows it constrains the number of times teh task is called, but the check for the number of times the Handle method is called does not meet expectations. The Handle method is being invoked many more times than the task .
…often than expected.
…op occuring after retries.
|
@cgillum, any timeline for reviewing the changes I made based on your comment? |
Add attributes to RetryPolicy.Handle property.
Handle: remove Obsolete attribute and add to summary.
|
Hello, is there any approximate date when will this be released? |
|
@jviau or @davidmrdavid, when is the next planned release of the .NET Isolated SDK? |
|
I have been monitoring nuget for updates. Once there is a prerelease, I will perform some additional testing. Also hoping the Schedule orchestration feature fix is also in the next release. |
|
@cgillum, any update on a release date? Odd that it has been over 3 months since the PR was completed and nothing has been made available. |
|
I believe @jviau is still on leave until the end of this month. @davidmrdavid, @AnatoliB, or @lilyjma can we come up with a plan for updating the .NET Isolated release in the meantime? |
|
I tested the new nuget packages and the HandleFailure method worked for me. Thanks for finally get this released. Will save on unnecessary compute. |
|
@cgillum Is there any reason why TaskFailureDetails are used as Func argument? I want to retry on two types of transient errors:
With current implementation it cannot be achieved as far as I know. Would it make sense to e.g. serialize the original Exception within TaskFailureDetails? Or if TaskFailureDetails shouldn't grow much, maybe there should be some other flow? This non-implemented function would fit more or less on my use case, is there any particular reason why wasn't it implemented? |
|
Hi @kobudzik. I think your question(s) might be best to have in a separate GitHub issue since they don’t appear to be simple. Please create an issue and feel free to tag me there. That way we can go into more details without automatically notifying all the participants in this PR. |
6 participants
Add Handle delegate property to RetryPolicy and ensure it is passed to CoreRetryOptions so users of RetryPOlicy have ability to determine retry policy based on exception,
Testing shows it correctly constrains the number of times the task is called, but the check for the number of times the Handle method is called does not meet expectations. The Handle method is being invoked many more times than the task .